Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OsStatsTests by providing always a positive long #57336

Merged
merged 1 commit into from
May 29, 2020

Conversation

iverase
Copy link
Contributor

@iverase iverase commented May 29, 2020

Make sure we always provide a positive long

fixes #57333

@iverase iverase added >test Issues or PRs that are addressing/adding tests :Data Management/Monitoring v8.0.0 labels May 29, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Monitoring)

@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label May 29, 2020
@iverase iverase requested a review from danhermann May 29, 2020 08:54
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iverase iverase merged commit 3fc0d29 into elastic:master May 29, 2020
@iverase iverase deleted the fixOsStatsTests branch May 29, 2020 09:03
@iverase
Copy link
Contributor Author

iverase commented May 29, 2020

Thanks @martijnvg!

danhermann pushed a commit to danhermann/elasticsearch that referenced this pull request May 29, 2020
danhermann pushed a commit to danhermann/elasticsearch that referenced this pull request May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Monitoring Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] testGetUsedMemoryWithZeroTotal & testGetUsedSwapWithZeroTotal fail
4 participants